(history): Drop states borrow before callback invocation #285
Conversation
|
I do not believe the test failures are my fault; but I cannot seem to run tests locally (maybe nixos is a problem?) so I can't be sure. |
|
Can you add a test for this? |
I can certainly try. As I noted though, the test suite as a whole will not run for me. Do you have a suggestion as to a test I could use as reference? |
|
You can look at any of the tests in the history crate as a reference. If you can't run the tests locally (which should be easy with wasm-pack), you can just push the changes and let the CI run those tests. The history tests currently pass so if anything goes wrong, the "browser tests" workflow will fail |
|
Cool, I'll do my best to sort a test out tomorrow evening; I've been a tad busy working on my app today (with this patch in place) :D |
CI should now pass if you merge the changes. |
To prevent situations of 'already mutably borrowed: BorrowError' when invoking callbacks from BrowserHistory where state is in use, drop the borrow before invoking the callbacks. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
|
Thanks @futursolo I managed to get wasm-pack to run history tests well enough to test the small change I added to the browser-history test to confirm that this approach is right. @hamza1311 Do you want me to cover all the state related functions or is this enough? |
|
Released in gloo-history 0.1.3 🎉 |
Fantastic, thank you |
To prevent situations of 'already mutably borrowed: BorrowError' when invoking callbacks from BrowserHistory where state is in use, drop the borrow before invoking the callbacks.
This fixes #284