Address review

rustwasm · Feb 11, 2023 · 16193f6 · 16193f6
1 parent 76469b3
commit 16193f6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 136 deletions.
diff --git a/crates/test-macro/src/lib.rs b/crates/test-macro/src/lib.rs
@@ -201,5 +201,5 @@ fn find_ident(iter: &mut impl Iterator<Item = TokenTree>) -> Option<Ident> {
 }
 
 fn compile_error(span: Span, msg: &str) -> proc_macro::TokenStream {
-    quote_spanned! { span => compile_error!(#msg) }.into()
+    quote_spanned! { span => compile_error!(#msg); }.into()
 }
diff --git a/crates/test-macro/ui-tests/should_panic.stderr b/crates/test-macro/ui-tests/should_panic.stderr
@@ -1,186 +1,51 @@
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:28:15
-   |
-28 | #[should_panic::error]
-   |               ^^
-   |
-help: change the delimiters to curly braces
-   |
-28 | #[should_panic{}error]
-   |               ~
-help: add a semicolon
-   |
-28 | #[should_panic::;error]
-   |                 +
-
 error: malformed `#[should_panic = "..."]` attribute
   --> ui-tests/should_panic.rs:28:15
    |
 28 | #[should_panic::error]
    |               ^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:32:18
-   |
-32 | #[should_panic = 42]
-   |                  ^^
-   |
-help: change the delimiters to curly braces
-   |
-32 | #[should_panic = {}]
-   |                  ~
-help: add a semicolon
-   |
-32 | #[should_panic = 42;]
-   |                    +
-
 error: malformed `#[should_panic]` attribute
   --> ui-tests/should_panic.rs:32:18
    |
 32 | #[should_panic = 42]
    |                  ^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:36:15
-   |
-36 | #[should_panic[]]
-   |               ^^
-   |
-help: change the delimiters to curly braces
-   |
-36 | #[should_panic{}]
-   |               ~
-help: add a semicolon
-   |
-36 | #[should_panic[];]
-   |                 +
-
 error: malformed `#[should_panic = "..."]` attribute
   --> ui-tests/should_panic.rs:36:15
    |
 36 | #[should_panic[]]
    |               ^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:40:15
-   |
-40 | #[should_panic(42)]
-   |               ^^^^
-   |
-help: change the delimiters to curly braces
-   |
-40 | #[should_panic{}]
-   |               ~
-help: add a semicolon
-   |
-40 | #[should_panic(42);]
-   |                   +
-
 error: malformed `#[should_panic(...)]` attribute
   --> ui-tests/should_panic.rs:40:15
    |
 40 | #[should_panic(42)]
    |               ^^^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:44:15
-   |
-44 | #[should_panic(test)]
-   |               ^^^^^^
-   |
-help: change the delimiters to curly braces
-   |
-44 | #[should_panic{}]
-   |               ~
-help: add a semicolon
-   |
-44 | #[should_panic(test);]
-   |                     +
-
 error: malformed `#[should_panic(...)]` attribute
   --> ui-tests/should_panic.rs:44:15
    |
 44 | #[should_panic(test)]
    |               ^^^^^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:48:15
-   |
-48 | #[should_panic(expected)]
-   |               ^^^^^^^^^^
-   |
-help: change the delimiters to curly braces
-   |
-48 | #[should_panic{}]
-   |               ~
-help: add a semicolon
-   |
-48 | #[should_panic(expected);]
-   |                         +
-
 error: malformed `#[should_panic(...)]` attribute
   --> ui-tests/should_panic.rs:48:15
    |
 48 | #[should_panic(expected)]
    |               ^^^^^^^^^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:52:15
-   |
-52 | #[should_panic(expected::error)]
-   |               ^^^^^^^^^^^^^^^^^
-   |
-help: change the delimiters to curly braces
-   |
-52 | #[should_panic{}]
-   |               ~
-help: add a semicolon
-   |
-52 | #[should_panic(expected::error);]
-   |                                +
-
 error: malformed `#[should_panic(...)]` attribute
   --> ui-tests/should_panic.rs:52:15
    |
 52 | #[should_panic(expected::error)]
    |               ^^^^^^^^^^^^^^^^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:56:3
-   |
-56 | #[should_panic(expected =)]
-   |   ^^^^^^^^^^^^
-   |
-help: change the delimiters to curly braces
-   |
-56 | #[{}(expected =)]
-   |   ~
-help: add a semicolon
-   |
-56 | #[should_panic;(expected =)]
-   |               +
-
 error: malformed `#[should_panic]` attribute
   --> ui-tests/should_panic.rs:56:3
    |
 56 | #[should_panic(expected =)]
    |   ^^^^^^^^^^^^
 
-error: macros that expand to items must be delimited with braces or followed by a semicolon
-  --> ui-tests/should_panic.rs:60:27
-   |
-60 | #[should_panic(expected = 5)]
-   |                           ^
-   |
-help: change the delimiters to curly braces
-   |
-60 | #[should_panic(expected = {})]
-   |                           ~
-help: add a semicolon
-   |
-60 | #[should_panic(expected = 5;)]
-   |                            +
-
 error: malformed `#[should_panic]` attribute
   --> ui-tests/should_panic.rs:60:27
    |