Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threadsafe futures #1514

Merged
merged 18 commits into from
Jul 19, 2019
Merged

Threadsafe futures #1514

merged 18 commits into from
Jul 19, 2019

Commits on Jul 16, 2019

  1. added polyfill for Atomics.wait and used it to notify futures

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    d1d3021 View commit details
    Browse the repository at this point in the history

  2. typo fixed in Atomics docs

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    c01575c View commit details
    Browse the repository at this point in the history

  3. added polyfill implementation in rust

    @ibaryshnikov
    ibaryshnikov authored and ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    2fdfe79 View commit details
    Browse the repository at this point in the history

  4. moved threadsafe futures behind a flag

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    e466e1a View commit details
    Browse the repository at this point in the history

  5. moved threadsafe futures implementation to a separate file, made upda… 

    …tes after review
    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    16c6bdc View commit details
    Browse the repository at this point in the history

  6. placed web-sys dependency behind a feature flag in wasm-bindgen-futures

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    06c783d View commit details
    Browse the repository at this point in the history

  7. updated default timeout and wait_async signature in wasm-bindgen-futures

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    221dc73 View commit details
    Browse the repository at this point in the history

  8. moved lib.rs to stable.rs in wasm-bindgen-futures, updated during review

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    6ab1a49 View commit details
    Browse the repository at this point in the history

  9. added documentation comment for a stable version of wasm-bindgen-futures

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    cbaa1d3 View commit details
    Browse the repository at this point in the history

  10. updated to the latest master

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    45d2c7c View commit details
    Browse the repository at this point in the history

  11. removed AtomicBool from Waker struct

    @ibaryshnikov
    ibaryshnikov committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    02be369 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Emit a compiler error with futures 0.3 and atomics 

    Not implemented yet, and the one there doesn't work with atomics! (we'll
get around to this soon-ish)
    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d122bbc View commit details
    Browse the repository at this point in the history

  2. Update parallel raytrace example to use futures 

    Use the atomics support now implemented!
    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    9f77f8d View commit details
    Browse the repository at this point in the history

  3. Clean up atomics/futures + polyfill 

    * Remove now-unneeded `State` enum
* Remove timeout argument from polyfill since we don't need it
* Call `Atomics.waitAsync` if it's available instead of using our polyfill
* Remove some extraneous dead code from the polyfill
* Add a `val: i32` argument to the polyfill
* Simplify the flow of futures with `Package` since `waitAsync` handles
  all the heavy lifting for us.
* Remove `Arc<Package>` and just use `Package`
* Remove `RefCell` from inside of `Package` now that it is no longer
  needed.
    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    cde9684 View commit details
    Browse the repository at this point in the history

  4. Deduplicate JsFuture definitions 

    Turns out it's the exact same for both before and after atomics, so
let's use the same definition!
    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d590a9e View commit details
    Browse the repository at this point in the history

  5. Rename some files 

    * Use "legacy" instead of "stable" since `futures 0.1` is quicly
  becoming "legacy"
* Rename "atomics" to "legacy_atomics" to leave room for the
  libstd-based futures atomics version.
* Rename "polyfill" to "wait_async_polyfill" to specify what it's
  polyfilling.
    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    c8451d6 View commit details
    Browse the repository at this point in the history

  6. Remove a debugging statement

    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    be294c8 View commit details
    Browse the repository at this point in the history

  7. Shared more betwee legacy with/without atomics

    @alexcrichton
    alexcrichton committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    b13f757 View commit details
    Browse the repository at this point in the history