Work around rust-lang/rust#58516 #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm weird! So stylistically this is definitely a step backwards, but it seems reasonable if it's working around an LLVM bug. Can you be sure to leave comments explaining the duplication though so we know what to do with this when encountering it in the future? |
|
Will do. Do you want me to drop the redundant loop as well, or shall I keep it so the two versions are closer to each other? |
|
Seems reasonable! |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it looks like the loop could be dropped completely in the "not-strict-macro" case but I wasn't sure if used.get() might panic or something.