Don't emit mutable globals #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Dec 5, 2020
We emit a shim function that sets the stack pointer, so we can avoid emitting mutable globals. Mutable globals aren't supported everywhere Wasm is.
|
@alexcrichton I've resolved all the comments from your previous review :) |
|
Thanks! |
|
Which version will include the improvement? I need it as well. @alexcrichton |
|
I've done a version bump at #2435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed fix for #2386, based on @alexcrichton's comment here: #2386 (comment)
We emit a shim function that sets the stack pointer, so we can avoid emitting mutable globals.
Mutable globals aren't supported everywhere Wasm is.
This PR seems to pass tests, but I believe it doesn't actually avoid exporting the stack pointer yet.
I'm not sure where to look for that, and I imagine we should add a test to ensure we actually don't export mutable globals.
This is my first foray into the
wasm-bindgencodebase, so I expect there to be some mistakes in this code.I think I might still need to modify
export_shadow_stack_pointerto not export it to the wasm module...