Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrollHeight, and scrollTop to allow scrolling #2453

Closed
wants to merge 3 commits into from
Closed

Add scrollHeight, and scrollTop to allow scrolling #2453

wants to merge 3 commits into from

Conversation

vthg2themax
Copy link
Contributor

Let me know if there's anything else you need.

@vthg2themax vthg2themax changed the title Add scrollHeight, and scrollTop to allow scolling Add scrollHeight, and scrollTop to allow scrolling Feb 12, 2021
@vthg2themax
Copy link
Contributor Author

Is your windows test machine not working to cause failing tests, or did I forget something?

@alexcrichton
Copy link
Contributor

Thanks for the PR! This source, however, is auto-generated from the WebIDL files in this repository. CI checks that the generated source matches what we'd expect, so to alter the source you need to modify the code generator or the WebIDL files, not just the source directly.

@vthg2themax
Copy link
Contributor Author

Thank you very much! I will amend my changes to the correct spot, and try again.

@vthg2themax
Copy link
Contributor Author

I changed the webIDL, it looked correct, does that mean I should not have also changed the output?

@alexcrichton
Copy link
Contributor

Landed in #2458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vthg2themax @alexcrichton