Skip to content

Upgrade the webpack-based examples' npm dependencies (move to webpack 5) #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

thomasetter
Copy link
Contributor

This is mostly:

$ fd webpack.config.js examples/ | xargs sed "s/mode: 'development'/mode: 'development',\n    experiments: {\n        asyncWebAssembly: true\n   }/" -i

$ fd package.json examples/ | xargs sed 's/serve": "webpack-dev-server/serve" : "webpack serve/' -i

And in each folder touched by the above:

$ ncu -u && npm update && npm update --dev

The weather_report and the webxr examples needed minor adjustments, but besides that everything seems to

The examples seem to work, except ducktype and guide-supported-types which build, but I could not really see anything in the browser.
This was the same for me before this change, please let me know if this is not expected.

…ings) upgrades them to webpack 5

For the weather_report, had to choose the syncWebAssembly experiment,
whereas the rest works fine with asyncWebAssembly
…orkspace.

This currently fails with:
error: current package believes it's in a workspace when it's not:
current:
<project-root>/examples/weather_report/Cargo.toml
workspace: <project-root>/Cargo.toml
@alexcrichton
Copy link
Contributor

Thanks!

@alexcrichton alexcrichton merged commit 2ccdbd9 into rustwasm:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants