Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bindings for WebAssembly.Tag and WebAssembly.Exception #3484

Merged
merged 5 commits into from
Jun 16, 2023
Merged

Add bindings for WebAssembly.Tag and WebAssembly.Exception #3484

merged 5 commits into from
Jun 16, 2023

Conversation

allsey87
Copy link
Contributor

@allsey87 allsey87 commented Jun 16, 2023 •
edited
Loading

Add bindings for WebAssembly.Tag and WebAssembly.Exception. These new objects are documented on MDN and are available in both Firefox and Chrome.

@allsey87
Copy link
Contributor Author

I am a little bit confused about why the "CI / Run UI compile-fail tests" are failing. It seems to me that this is unrelated to this PR.

@daxpedda
Copy link
Collaborator

The CI failure is because you introduces new #[wasm_bindgen] types, so there are more types now that can be converted from JsValue.
To fix it you have to increase this line to 74.

daxpedda
daxpedda requested changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebAssembly.Tag only exists in the editors draft and isn't in the working draft yet. But it is implemented on all browsers, so I think it's fine to add this.

Could you add a changelog entry as well?

daxpedda
daxpedda reviewed Jun 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@allsey87 @daxpedda
Update CHANGELOG.md
4f50bde 
Co-authored-by: daxpedda <daxpedda@gmail.com>
daxpedda
daxpedda approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 165ad00 into rustwasm:main Jun 16, 2023
@allsey87
Copy link
Contributor Author

Thanks for the fast review & merge @daxpedda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allsey87 @daxpedda