use fully qualified names in wasm_bindgen_test for items exported from std prelude
#3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hlbarber
changed the title
wasm_bindgen_test for items exported from std prelude
ranile
approved these changes
Aug 7, 2023
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Aug 17, 2023
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
davidbarsky
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Sep 26, 2023
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
davidbarsky
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Sep 27, 2023
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
davidbarsky
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Sep 27, 2023
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
davidbarsky
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Sep 27, 2023
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Oct 1, 2023
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
wasm_bindgen_testmacro dooes not use fully qualified names for items exported from the prelude. This means that naming collisions (struct Some) or the removal of the std library prelude will cause compilation errors.Solution
::corerather than::std.no_implicit_preludetocrates/test-macro/ui-tests/should_panic.rs.