Add support for testing in more worker types #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
thread-types
branch
from
12097ef
to
056a72d
Compare
Liamolucko
approved these changes
Jan 23, 2024
Co-Authored-By: Liam Murphy <43807659+Liamolucko@users.noreply.github.com>
daxpedda
force-pushed
the
thread-types
branch
from
be94f88
to
8b900b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for testing in shared and service worker as a follow up to #3340.
Notably I deprecated
run_in_workerin favor ofrun_in_dedicated_workerand introducedrun_in_shared_workerandrun_in_service_worker.Keep in mind that Firefox doesn't support
importnorimportScriptin service workers, so this has to be tested on Chrome. See the Bugzilla bug report.I also reverted parts of #3351 that added some now outdated workarounds for Firefox lacking module support in workers.