Add sorted_iter_mut for NonstandardWitSection.adapters for determinism #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested changes
Feb 22, 2024
Aaron1011
force-pushed
the
adpaters-btreemap
branch
from
d6e66a9
to
7078c80
Compare
Aaron1011
changed the title
|
I've updated this to add a new |
daxpedda
requested changes
Feb 22, 2024
In the `externref` code, we call `export_xform` while iterating over `adapters` with `iter_mut`. Calling `export_xform` can result in shims, with the id depending on the order in which we iterate over the exports. To make the final .wasm output deterministic, I've changed this to use a new `sorted_iter_mut` method (based on `sorted_iter`).
Aaron1011
force-pushed
the
adpaters-btreemap
branch
from
7078c80
to
1cf8f92
Compare
|
I updated the changelog |
|
Is there a plan, or estimation, on when |
|
I will try to make a new release at the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
externrefcode, we callexport_xformwhile iterating overadapterswithiter_mut. Callingexport_xformcan result in shims, with the id depending on the order in which we iterate over the exports.This makes the .wasm output deterministic when using
--reference-types