Don't allow invalid Unicode scalar values in char
#3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liamolucko
reviewed
Mar 2, 2024
daxpedda
commented
Mar 2, 2024
| self.global( | ||
| " | ||
| function _assertChar(c) { | ||
| if (typeof(c) === 'number' && (c >= 0x110000 || (c >= 0xD800 && c < 0xE000))) throw new Error(`expected a valid Unicode scalar value, found ${c}`); |
There was a problem hiding this comment.
I believe this should work, I also added a couple of tests for this as well.
Liamolucko
reviewed
Mar 3, 2024
tests/wasm/char.rs
Outdated
Comment on lines
26
to
29
| #[wasm_bindgen] | ||
| pub fn rust_js_option_identity(c: Option<char>) -> Option<char> { | ||
| js_option_identity(c) | ||
| } |
There was a problem hiding this comment.
This doesn't seem to be used.
|
CI is currently broken because of rust-lang/rust#121932, which will be fixed tomorrow (hopefully) by rust-lang/rust#121933. |
Liamolucko
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds runtime checks for passing
charfrom JS, which prevents invalid Unicode scalar values.Fixes #2269.