Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emitted package.json structure #4091

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix emitted package.json structure #4091

merged 2 commits into from
Aug 27, 2024

Conversation

kawaemon
Copy link
Contributor

Currently it emits incorrectly structured package.json like this:

{
  "foo": "^0.21.1",
  "bar": "^0.21.4"
}

This PR fixes it to match the spec.

{
  "dependencies": {
    "foo": "^0.21.1",
    "bar": "^0.21.4"
  }
}

@kawaemon kawaemon mentioned this pull request Aug 25, 2024
Merged
daxpedda
daxpedda approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 125aa23 into rustwasm:main Aug 27, 2024
41 checks passed
@kawaemon kawaemon deleted the fix-package-json branch August 27, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawaemon @daxpedda