Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-sys] add setConfiguration to RtcPeerConnection #4105

Merged
merged 5 commits into from
Sep 16, 2024
Merged

[web-sys] add setConfiguration to RtcPeerConnection #4105

merged 5 commits into from
Sep 16, 2024

Conversation

k-wasniowski
Copy link
Contributor

@k-wasniowski k-wasniowski commented Sep 6, 2024 •
edited
Loading

This PR adds setConfiguration to RTCPeerConnection object.
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/setConfiguration

@k-wasniowski k-wasniowski changed the title feat: add setConfiguration to RtcPeerConnection [web-sys] add setConfiguration to RtcPeerConnection Sep 6, 2024
@k-wasniowski k-wasniowski mentioned this pull request Sep 6, 2024
Closed
@k-wasniowski k-wasniowski force-pushed the add-set-configuration-to-rtcpeerconnection branch from 3ba65f4 to af23f76 Compare September 7, 2024 06:11
daxpedda
daxpedda requested changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a changelog entry.

Otherwise looks good, thank you!

crates/web-sys/webidls/enabled/RTCPeerConnection.webidl Outdated Show resolved Hide resolved
crates/web-sys/webidls/enabled/RTCPeerConnection.webidl Outdated Show resolved Hide resolved
@daxpedda daxpedda added the waiting for author Waiting for author to respond label Sep 7, 2024
@k-wasniowski
Copy link
Contributor Author

Missing a changelog entry.

Otherwise looks good, thank you!

Thank you for your review! Updated changelog and regenerated bindings

@daxpedda daxpedda removed the waiting for author Waiting for author to respond label Sep 16, 2024
daxpedda
daxpedda approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda daxpedda merged commit 20c010d into rustwasm:main Sep 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-wasniowski @daxpedda