-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed generated types for getters and setters #4202
Fixed generated types for getters and setters #4202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits.
Co-authored-by: daxpedda <daxpedda@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I will give it another review with a fresh set of eyes tomorrow.
Thank you, this is great work!
Co-authored-by: daxpedda <daxpedda@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, was sick and had to play catch-up with my other projects before getting back to this again.
LGTM!
No worries. I'm glad you're feeling better! And thanks for the review! |
While working on #4201, I had the idea to test how wasm bindgen handles getter-setter pairs with different types. Not well was the answer.
This PR completely changes how the type definitions for getters and setters are generated and fixes several bugs:
There were also some minor issues:
This PR fixes all of those issues and adds a test to verify correctness.
Fixing these issues is a requirement for #4188 and #4201.