-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for i128 and u128 #4222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting to draft until #4246 is resolved. |
daxpedda
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Just some nits and a changelog entry missing.
daxpedda
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
TylerJang27
pushed a commit
to TylerJang27/wasm-bindgen
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2822
This adds WASM ABI support for
i128
andu128
. Both are split into 2u64
and passed as such in the ABI.The following types can now be used in argument and return positions:
i128
,u128
,Option<i128>
, andOption<u128>
. Return positions can also useResult<i128, E>
andResult<u128, E>
.It's important to note that
Result<Option<i128>, E>
is not supported. This is because theWasmAbi
trait supports at most 4 primitives, butResult<Option<i128>, E>
would require 5 primitives (2 fori128
, 1 for the option tag, 1 for the result tag, and 1 for the error variant value). FutureResult<Option<T>, E>
ABI optimizations (either combining the result and option tag into one primitive, or raising the number of supported primitives to 5) will makeResult<Option<i128>, E>
possible, but this should be a separate PR IMO.Related to #4201.