Fixed imports with late binding and this
#4225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4214
The problem in #4214 was that function like
document.write
can't be imported as a function reference into WASM directly, becausedocument.write
does not capture thethis
argument (heredocument
). Or in other words, there is a difference between:and
However, aside from
this
not being captured, the (let's called it) direct import style also didn't support late binding. If the object or function is only defined after the WASM module is instantiated, then the direct import style will cause an error.This PR fixes both issues by always generating a wrapper function for imported function from global scope.