Add missing isPointInFill and isPointInStroke methods for SVGGeometryElement (web-sys idl update) #4509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacgillivray
changed the title
|
Re: failing checks, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing isPointInFill and isPointInStroke methods to SVGGeometryElement idl.
Fixes #4507
For the fix, I read the contributing guidelines regarding the web-sys package. Once I figured out how the interfaces are built from the IDLs, I found the SVGGeometryElement IDL on w3.org and added the missing interfaces. Then, I compiled using the instructions for adding new web-sys APIs.
The generated interfaces looked correct to me so I figured I'd go ahead and make a PR. Hope this helps. Let me know if this isn't quite correct!