Gate web-sys APIs on activated features
#790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: lots of CI failures |
Currently the compile times of `web-sys` are unfortunately prohibitive, increasing the barrier to using it. This commit updates the crate to instead have all APIs gated by a set of Cargo features which affect what bindings are generated at compile time (and which are then compiled by rustc). It's significantly faster to activate only a handful of features vs all thousand of them! A magical env var is added to print the list of all features that should be generated, and then necessary logic is added to ferry features from the build script to the webidl crate which then uses that as a filter to remove items after parsing. Currently parsing is pretty speedy so we'll unconditionally parse all WebIDL files, but this may change in the future! For now this will make the `web-sys` crate a bit less ergonomic to use as lots of features will need to be specified, but it should make it much more approachable in terms of first-user experience with compile times.
alexcrichton
force-pushed
the
lots-of-features
branch
from
7f2acff
to
97bd967
Compare
|
Ok I think CI is green, AppVeyor seems to have terminated but doesn't explain why... |
fitzgen
approved these changes
Sep 5, 2018
| # the features must all be manually activated. | ||
| [features] | ||
| AbortController = [] | ||
| AbortSignal = [] |
There was a problem hiding this comment.
Oh also: this comment about features should probably go into the README and/or src/lib.rs too
| // Iteratively prune all entries from the AST which reference undefined | ||
| // fields. Each pass may remove definitions of types and so we need to | ||
| // reexecute this pass to see if we need to keep removing types until we | ||
| // reach a steady state. |
There was a problem hiding this comment.
One might describe the pruning as a monotonic function, and iterating to a fixed point with this monotonic function as a "monotone framework"... ;)
| None => return, | ||
| }; | ||
| let mut required = BTreeSet::new(); | ||
| item.imported_type_references(&mut |f| { |
There was a problem hiding this comment.
Super happy that this ended up being generally useful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the compile times of
web-sysare unfortunately prohibitive,increasing the barrier to using it. This commit updates the crate to instead
have all APIs gated by a set of Cargo features which affect what bindings are
generated at compile time (and which are then compiled by rustc). It's
significantly faster to activate only a handful of features vs all thousand of
them!
A magical env var is added to print the list of all features that should be
generated, and then necessary logic is added to ferry features from the build
script to the webidl crate which then uses that as a filter to remove items
after parsing. Currently parsing is pretty speedy so we'll unconditionally parse
all WebIDL files, but this may change in the future!
For now this will make the
web-syscrate a bit less ergonomic to use as lotsof features will need to be specified, but it should make it much more
approachable in terms of first-user experience with compile times.