Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustc --crate-type for smoother multi-target compilation in build stage #1329

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use rustc --crate-type for smoother multi-target compilation in build stage #1329

wants to merge 5 commits into from

Conversation

tronicboy1
Copy link

@tronicboy1 tronicboy1 commented Sep 14, 2023 •
edited
Loading

Description

Changes the use of cargo build internally to cargo rustc and adds the --crate-type cdylib flag for smoother multi-target compilation.

Closes #1297

Make sure these boxes are checked! πŸ“¦βœ…

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ πŸ˜„ Thanks so much for contributing to wasm-pack! πŸ˜„ ✨✨

@tronicboy1 tronicboy1 changed the title Feature/1297/crate type flag in cargo build Use rustc --crate-type for smoother multi-target compilation in build stage Sep 14, 2023
@tronicboy1 tronicboy1 mentioned this pull request Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using --crate-type for smoother multi-target compilation
1 participant
@tronicboy1