fix: Handle both underscores and hypthens as separators in "wasm-bind… #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
force-pushed
the
hyphens-and-underscores
branch
2 times, most recently
from
0878e98 to
12210c2
Compare
data-pup
reviewed
Aug 25, 2018
| style("wasm-bindgen").bold().dim() | ||
| )) | ||
| get_wasm_bindgen_version(path)?; | ||
| Ok(()) |
data-pup
reviewed
Aug 25, 2018
src/manifest.rs
Outdated
| match deps | ||
| .get("wasm-bindgen") | ||
| .or_else(|| deps.get("wasm_bindgen")) | ||
| { |
data-pup
approved these changes
Aug 25, 2018
|
Looking into the test that failed, it seems to be related to that fixture's wasm-bindgen dependency in its Cargo.toml, if I understand correctly? |
3 tasks
fitzgen
force-pushed
the
hyphens-and-underscores
branch
from
12210c2 to
0b669ec
Compare
…gen" dependencies
fitzgen
force-pushed
the
hyphens-and-underscores
branch
from
0b669ec to
b480674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gen" dependencies
Make sure these boxes are checked! 📦✅
rustfmtinstalled and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightlyrustfmton the code base before submittingYou reference which issue is being closed in the PR text✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨