Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency filelock to v3.15.4 #1961

Merged
merged 1 commit into from
Jun 22, 2024
Merged

chore(deps): update dependency filelock to v3.15.4 #1961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ click = "==8.1.7"
colorama = "==0.4.6"
coverage = "==7.5.3"
distlib = "==0.3.8"
filelock = "==3.15.3"
filelock = "==3.15.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filelock module was updated from 3.15.3 to 3.15.4. It would be great to clarify what prompted this change. It's important to ensure that the updated version is compatible with rest of the codebase.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update is made to the 'filelock' package version in the Pipfile. Make sure that this version update doesn't introduce any breaking changes with the existing codebase.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of 'filelock' package is being updated here. It would be necessary to verify if this new version doesn't have any breaking changes that could potentially affect other parts of your project.

flake8 = "==7.1.0"
flake8-black = "==0.3.6"
identify = "==2.5.36"
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ click==8.1.7
colorama==0.4.6; sys_platform == "win32" or platform_system == "Windows"
coverage==7.5.3
distlib==0.3.8
filelock==3.15.3
filelock==3.15.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, in the requirements.txt file, the filelock version was updated. If this change was done to fix a bug or add a feature, it would be good have a note here for future reference.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update is made to the 'filelock' package version in the requirements.txt. Ensure compatibility of this new package version with the rest of your environment.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same update on filelock version is noted here. Make sure again that this version update on the filelock package doesn't introduce any breaking changes.

flake8==7.1.0
flake8-black==0.3.6
identify==2.5.36
Expand Down
Loading