plugins: remove allowance for missing JSON id in commando.

Changelog-Removed: Plugins: no longer allow missing `id` field in commando requests (deprecated v23.02, EOL v24.02) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell · Feb 20, 2024 · 5945ec3 · 5945ec3
1 parent 8ff0288
commit 5945ec3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/doc/developers-guide/deprecations.md b/doc/developers-guide/deprecations.md
@@ -33,7 +33,6 @@ hidden: false
 | estimatefees.penalty                 | Field              | v23.05           | v24.05         | `penalty` feerate (implementation-specific, use modern feerates)                                                                                                                |
 | estimatefees.min_acceptable          | Field              | v23.05           | v24.05         | `min_acceptable` feerate (implementation-specific, use modern feerates)                                                                                                         |
 | estimatefees.max_acceptable          | Field              | v23.05           | v24.05         | `max_acceptable` feerate (implementation-specific, use modern feerates)                                                                                                         |
-| commando.missing_id                  | Parameter          | v23.02           | v24.02         | Incoming JSON commands without an `id` field                                                                                                                                    |
 | offer.recurrence_base.at_prefix      | Parameter          | v24.02           | v24.05         | `recurrence_base` with `@` prefix (use `recurrence_start_any_period`)                                                                                                           |
 
 

diff --git a/plugins/commando.c b/plugins/commando.c
@@ -397,8 +397,7 @@ static void try_command(struct commando *incoming STEALS)
 	}
 	filter = json_get_member(buf, toks, "filter");
 	id = json_get_member(buf, toks, "id");
-	if (!id && !command_deprecated_in_nocmd_ok(plugin, "commando.missing-id",
-						   "v23.02", "v24.02")) {
+	if (!id) {
 		commando_error(incoming, COMMANDO_ERROR_REMOTE,
 			       "missing id field");
 		return;