cln: specify --developer if supported. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
cln-developer-flag
branch
from
51ef9b2 to
5982cd7
Compare
This is being added instead of the build-time setting for v23.11. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
cln-developer-flag
branch
from
5982cd7 to
67aba83
Compare
vincenzopalazzo
approved these changes
Sep 21, 2023
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 21, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 21, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 21, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 22, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
rustyrussell
pushed a commit
to ElementsProject/lightning
that referenced
this pull request
Sep 25, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
cdecker
pushed a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Sep 26, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being added instead of the build-time setting for v23.11.