Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nodejs test due to upstream cargo-web issues with rust >= 1.44 #288

Merged
merged 6 commits into from
Jun 29, 2020

Conversation

shanemadden
Copy link
Collaborator

Temporarily comments out the test that's failing on current nightly builds.

@ASalvail
Copy link
Collaborator

Wouldn't it be easier to lock the api to rust 1.43?

@ASalvail ASalvail requested a review from daboross March 27, 2020 02:29
@shanemadden
Copy link
Collaborator Author

Quite possibly - not sure how to do that ;)

@ASalvail
Copy link
Collaborator

Right, that'd be in the testing environment. @daboross thoughts?

@daboross
Copy link
Collaborator

Both sound reasonable to me? If it's just the test that's failing, though, and not the entire build, then this seems reasonable.

We could have the tests only run on 1.43.0, but I don't know if the complexity would be worth it.

I don't know why travis is just at "Expected", though, not success or failing...

@shanemadden shanemadden deleted the nodejs_test_disable branch April 28, 2020 13:12
@shanemadden shanemadden restored the nodejs_test_disable branch June 25, 2020 17:39
@shanemadden
Copy link
Collaborator Author

Re-opening since we're hard blocked on these failures on stable in addition to nightly, so the workaround in #301 is no longer doing the job; unsure if this'll build or if we need additional tweaks to the travis.yml.

I've got a pretty bare hello world working with bindgen that's passing strings successfully (but not references yet), so we've got a couple steps down that road - but unfortunately it'll be a long one, and we'll be tied to stdweb's toolchain for a while yet.

@shanemadden shanemadden reopened this Jun 25, 2020
@Azaril
Copy link
Contributor

Azaril commented Jun 25, 2020

For what it's worth I have identified the core issue and reported it to cargo web - including specifics of potential fixes. However, both cargo-web and stdweb appear to be unmaintained with no updates in months. (I have PRs open against the projects that haven't been looked at.)

I'm unfortunately inclined to disable to tests for the moment so we can keep on latest stable. A migration to bindgen seems somewhat inevitable due to lack of support from cargo web/stdweb.

@shanemadden shanemadden changed the title Disable nodejs test due to issues with 1.44 nightly builds Disable nodejs test due to upstream cargo-web issues with rust >= 1.44 Jun 29, 2020
@Azaril Azaril self-requested a review June 29, 2020 19:45
@shanemadden shanemadden merged commit 922afdd into rustyscreeps:master Jun 29, 2020
@shanemadden shanemadden deleted the nodejs_test_disable branch July 10, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants