Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert from stdweb to wasm-bindgen #333

Merged
merged 188 commits into from
Mar 13, 2023
Merged

Convert from stdweb to wasm-bindgen #333

merged 188 commits into from
Mar 13, 2023

Conversation

shanemadden
Copy link
Collaborator

@shanemadden shanemadden commented Nov 20, 2020 •
edited
Loading

Resolves #329. 🎊
Resolves #156, resolves #246, resolves #287, resolves #308, resolves #316, resolves #328, resolves #331

See the temporary readme file added in the root for how to get started using this branch; there's some manual steps to hack the wasm-pack output for now.

Remaining to-do items:

  • Return codes - negative values aren't natively supported by bindgen for enums, so we're taking all return code returning functions as i8 right now. Implement better conversion for ReturnCode and change i8 function returns.
  • Logging - currently just referencing web-sys's console functions, get a good example going with fern.
  • Market - a bunch of return types need struct conversions instead of raw Object, and MarketResourceType conversion from JsString
  • Memory root - need to figure out how to get bindgen to return this object directly from the global scope fresh on each access, which is.. surprisingly confounding to figure out how to do? Document using the thing, and its children from creep/room/etc getters, using Reflect.
  • portal destinations - return type needs struct conversion
  • Room event logs - return types need struct conversion
  • Typed find/look_for calls
  • final - For all object prototype functions where it's safe, add the bindgen final keyword to link the functions more efficiently
  • structural - opposite of final, mark everything on the Game object, which gets re-created every tick, as explicitly structural even though that's currently the default
  • RoomVisual
  • MapVisual
  • Builds - let's move to GH actions as we move to new wasm-pack testing toolchain, since travis has been problematic.
  • Typed Object IDs - currently handling IDs as JsString without a local representation yet, work out how to deal with storing an object type along with an Id and resolving properly, preferably with support for at least both 24-char and 15-char 0-padded IDs (add to tests)
  • Structure typing - we have an enum on structureType that can be used to get the object type as an enum, but not yet as way to get a Structure as the narrowly typed structure within it
  • Chaining - types that support chaining in js like visual inputs should support chained calls
  • Code deployment - update cargo-screeps to support build/deploy of bindgen codebases (the hacks currently enshrined in the temporary readme) Convert from cargo-web to wasm-pack cargo-screeps#24
  • More doc examples - especially of 'tricky' stuff like passing Uint8Array::view() into a CostMatrix unsafely
  • Anything else I added a todo comment on and forgot about

Maybe:

  • Trait implementations - bindgen has opinions about how it hooks into the js inheritance hierarchy, does it make sense to re-implement our traits against the child object types or just expect passing a parent type AsRef as the API is now?
  • Terrain local representation, similar to the CostMatrix one, providing a fast rust-native interface to a Vec<u8> terrain buffer from js (notably with x/y flipped vs costmatrix pos_as_idx)

@shanemadden
Initial minimal commit of bindgen branch, beginning to port API from …
495b8dc 
…stdweb to wasm-bindgen

Only a couple of global functions as well as Room objects with some of their
functions are implemented so far
@shanemadden
Update notes with smoother rebind of loop name
6b71e3d
@shanemadden
Update work in progress, added a bunch of implementation coverage for…
a454a86 
… room object and structure prototypes and positions
@shanemadden
Add impls for Owner and OwnedStructure, plus some doc updates
b3176bc
@shanemadden
Move the FindType constant to small_enums
119e04c
@shanemadden
Large WIP update implementing a bunch of game types
7368594
@shanemadden
More work on constants and an initial minimal pathfinder implementation
5f47e3d
@shanemadden
bit more cpu
3d3c9c4
@shanemadden
Merge branch 'master' into bindgen
1247241
@shanemadden
Terrain, more position and room functions, and use console from web-sys
5ac79a4
@shanemadden
A few new extra constants, map, and intershard memory
67d7a2e
@shanemadden
Move costmatrix, initial market stuff
67fe8c1
@shanemadden
Merge branch 'master' into bindgen
bb2d931
@shanemadden
First take on hooking in local position and cost matrix
e93403f
@shanemadden
Add From impls for local matrix and position
84dc122
@shanemadden
format, big format
e7df741
@shanemadden
Remove js files
fc8e96c
@shanemadden
Delete unused code
8c65483
jollygreenlaser
jollygreenlaser reviewed Nov 20, 2020
View reviewed changes
Cargo.toml Outdated
Comment on lines 39 to 37
stdweb = "0.4"
stdweb-derive = "0.5"
wasm-bindgen = { version = "0.2", features = ["serde-serialize"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@shanemadden
lab range extra constant
c7d383e
@shanemadden
Minor fixes and a typed wrapper for getting narrow typed structures
dfa1be2
@shanemadden
tweak docs and return an untyped structure on unknown - maybe we'll k…
e79c04d 
…eep this?
@shanemadden
Implement RawObjectId as u128, with the most significant 96 bits used…
89f1c49 
… for id and the least significant 8 store the padding length to support variable padding
@shanemadden
Basic typed ids (still missing some needed stuff like resolve) and so…
18c10d2 
…me doc updates
@shanemadden
Add a couple more tests for oddball object IDs
ba5e3eb
@shanemadden
Add JsObjectId, which is a typed wrapper around a js heap stored obje…
89e8f98 
…ct id string, and some resolve wrappers
@shanemadden
Add some resolve functions and format
ad06d1d
@shanemadden
Terminal hits constant fix
244f691
@shanemadden
native object id resolve
86f5c75
@shanemadden
a bit of initial fiddling with enum_dispatch - tbd on passing in fn args
479e9d5
@shanemadden
Update some doc comments and clean up objects.rs
ea06cad
@shanemadden
Implement remaining game methods for Position (still needs FindOption…
f0b540a 
…s where RoomPosition does)
@shanemadden
Move JsObjectId to js_collections module
5a73849
@shanemadden
Rename room_position module to position for clarify vs RoomPosition p…
246e137 
…ure-javascript object
@shanemadden
fmt
e04b39f
@shanemadden
Implement return value handling for powerCreep.powers
d6a18d8
@shanemadden
Return types on remaining market functions, work around u64 boundary …
3878560 
…issues with f64
@shanemadden
Deal with return values of createFlag functions on Room/RoomPosition
9bcc192
@shanemadden
Reorder creep functions and add doc comments about features
8bf0af4
@shanemadden
Rename [Js]FindOptions to [Js]FindPathOptions to reflect their use an…
2f55d8b 
…d because we need the FindOptions name
@shanemadden
clippy changes to format strings
fa3188b
@shanemadden
Implement remaining findPath/findPathTo functions
d9d1705
@shanemadden
Move ROOM_SIZE to extra constants and use it for CostMatrix index math
9e9ee25
@shanemadden
Add options wrapper for find call
2438505
@daboross daboross mentioned this pull request Jan 4, 2023
Closed
@shanemadden shanemadden marked this pull request as ready for review March 5, 2023 03:00
@shanemadden shanemadden merged commit 6a7d44d into master Mar 13, 2023
@shanemadden shanemadden deleted the bindgen branch March 13, 2023 19:58
@shanemadden shanemadden mentioned this pull request Mar 13, 2023
Closed
@ASalvail
Copy link
Collaborator

I missed this! What an incredible milestone!
I might be tempted to give screeps another try now.

@shanemadden shanemadden mentioned this pull request Jul 4, 2023
Closed
@shanemadden shanemadden restored the bindgen branch July 21, 2023 22:56
@shanemadden shanemadden deleted the bindgen branch July 21, 2023 22:57
@shanemadden shanemadden mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jollygreenlaser jollygreenlaser jollygreenlaser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone