Manually implemented RawObjectId de/serialization to/from string #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would advise implementing human-readable versus compact formats as used in serde-rs/serde#1044 to allow human-readable while also using compact-encode during binary serialization. |
Dessix
requested changes
Apr 13, 2022
shanemadden
added a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard
serdede/serialize implementations stored theRawObjectIdu128as a limited precision number, such as1.2193937513084523e+38. This custom implementation stores the value instead as a human readable string.We could instead serialize this as a byte array for efficiency, but since the
serde_jsonformat is a lower efficiency mechanism anyway, I think defaulting to readability is better.