Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inquirer-ordinal-prompt and --ordered option #67

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

RecuencoJones
Copy link
Contributor

@RecuencoJones
Copy link
Contributor Author

Checks from Appveyor seem okay but actually failed:

https://ci.appveyor.com/project/ruyadorno/ipt/builds/33688334/job/476x3goog43ili81

test/fixtures/help Outdated Show resolved Hide resolved
@ruyadorno
Copy link
Owner

ruyadorno commented Jun 24, 2020

hi @RecuencoJones thank you so much! 🙏 https://www.npmjs.com/package/inquirer-ordinal-prompt looks awesome! 😄

I just have some small details I'd change there before landing it here:

  • might be better to have only inquirer as a peer dep and the others as dependencies? I know inquirer-autocomplete-prompt does it and it seems to me to reflect better the nature of the dependency relationship here
  • I'm a big proponent to starting packages from v1.0.0 since it makes life easier using semver later but that's just a preference, up to you to decide 😊

Checks from Appveyor seem okay but actually failed:

https://ci.appveyor.com/project/ruyadorno/ipt/builds/33688334/job/476x3goog43ili81

thanks for the heads up, I updated the appveyor config to see if it fixes it.

@RecuencoJones
Copy link
Contributor Author

Agree on both suggestions, I realized later after publishing that most surely I didn't need all that many peerDependencies!
Will also change to 1.0.0 after doing the changes.

src/index.js Outdated Show resolved Hide resolved
Copy link
Owner

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @RecuencoJones ❤️ This looks really awesome!

@ruyadorno ruyadorno merged commit 06f0afe into ruyadorno:master Jun 24, 2020
@ruyadorno
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants