Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
start
offset ofshallowSlice
does not fall on the start of the buffer, and bothstart
andend
fall on the same buffer, result contains extra trailing bytes. This happens because buffer start is adjusted first, thus invalidating computed internal end offsets, causing buffer end adjustment to produce incorrect results. Proposed fix simply adjusts first end, then start, as end adjustment has no effect on computed start offsets.