Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-end in shallow slice #43

Closed
wants to merge 2 commits into from
Closed

Fix zero-end in shallow slice #43

wants to merge 2 commits into from

Conversation

dy
Copy link

@dy dy commented Apr 18, 2017

For the case

bl.shallowSlice(0, 0)

bl returns full buffer, which seems to be wrong. So here is the fix.
Is there any sense in making bl.shallowSlice(0, -0)?

@dy
Copy link
Author

dy commented Apr 18, 2017

I guess you may want tests?

@dy
Copy link
Author

dy commented Apr 18, 2017

Oh no, it's broken

@mcollina
Copy link
Collaborator

I'm on vacation for the next two weeks, I will release when I come back.

@dy
Copy link
Author

dy commented Apr 20, 2017

Hm. Seems that here it will also break on single-buffer operation, like bl(Buffer('abcdef')).slice(2,4). Should cover that too (gotcha from audio-buffer-list)

@mcollina
Copy link
Collaborator

mcollina commented May 1, 2017

Check version v1.2.1, #44 might fix your bug.

@mcollina mcollina closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants