Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #102

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Conversation

achingbrain
Copy link
Contributor

Upgrades Buffer to fix bundle size increases for modules that have
already upgraded to Buffer@6.x.x elsewhere.

Also upgrades dev deps.

Upgrades Buffer to fix bundle size increases for modules that have
already upgraded to `Buffer@6.x.x` elsewhere.

Also upgrades dev deps.
Copy link
Owner

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @achingbrain

@mcollina I think we have to semver-major this since it's a minimum-runtime impacting change, see feross/buffer@840160f

There's another possibility of doing a "buffer": "5||6" to make it flexible because we currently don't care about the change in features but also want to fit nicely into the background of large dependency trees. But that will still default to 6.x and therefore be a breaking change in most cases.

@mcollina feel free to merge & release when you see this, my vote is for a semver-major bump with this PR as is (tho open to 5||6).

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Collaborator

mcollina commented Apr 1, 2021

I would go for a semver-major bump as well. I'll see if I can get to it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants