Link Internal Buffers when appending another BufferList #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this._bufs.push(isBuffer ? buf : new Buffer(buf)) | ||
| this.length += buf.length | ||
| if (buf instanceof BufferList) { | ||
| this._bufs = this._bufs.concat(buf._bufs) |
There was a problem hiding this comment.
Should we do this._bufs.push.apply(this._bufs, buf._bufs) to prevent creation of a new array?
|
Im ok with this, can you forsee anyways this could break current code? It should work transparently so I'm ok with releasing this as patch. |
This provides support for node v5.6.0. Fixes #26.
mcollina
force-pushed
the
node-v5.6.0
branch
from
0bd6c46
to
649eb39
Compare
|
No I think this is ok and good. The test passed as is, so I don't foresee any issue. @rvagg ? |
|
Let's go with this as patch and #28 as minor cause it's adding features, sorry I missed this one! |
|
just pushed out v1.0.3 with this |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores support for node v5.6.0. I think we should release it as a patch upgrade, as the side effects of appending to a nested
bl()was a bug anyway.@rvagg @jcrugzz opinions?
Fixes #26