detect .pipe instead of using instanceof #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
sindresorhus' is-stream has the duck typing |
Repository owner
closed this by deleting the head repository
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using instanceof is problematic since it means that any compatible alt streams implementations that would interface cleanly with core streams won't be properly detected.
In a browser context, importing stream just to check instanceof is especially problematic since you end up with multiple different copies of stream implementations, duplicating many bytes over the wire.
Instead, I propose just making sure that
objis an object and that it has apipemethod that is a function. Where I have written this functionality elsewhere, that approach has proved plenty adequate.