Fix luerl_new:decode returning incorrect state #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should note that the same issue happens if |
davydog187
force-pushed
the
callback-bug
branch
from
85c5df0
to
95d3f67
Compare
Callbacks passed to functions implemented in Erlang as `erl_func` in the
likes were not updating state correctly.
For example, imagine the following Lua program
```lua
globalVar = { a = 1 }
function modify_global()
globalVar['b'] = 2
end
external_call(modify_global)
return globalVar
```
`external_call` is a function implemented in Erlang as
```erlang
ExternalFun = fun([Fun], S) ->
{FunRef, NewState1} = luerl_new:encode(Fun, S),
io:format("Function ref: ~p~n", [FunRef]),
{ok, Res, NewState2} = luerl_new:call(FunRef, [], NewState1),
{Res, NewState2}
end,
State = luerl_new:init(),
{ok, [], State1} = luerl_new:set_table_keys_dec([<<"external_call">>], ExternalFun, State),
```
This program returns
```erlang
% Expected
[[{<<"a">>, 1}, {<<"b">>, 2}]]
% Actual
[[{<<"a">>, 1}}]]
```
- [X] Write a test case that reproduces the problem
- [ ] Fix the root cause
davydog187
force-pushed
the
callback-bug
branch
from
95d3f67
to
3793e8e
Compare
davydog187
added a commit
to tv-labs/lua
that referenced
this pull request
Oct 22, 2024
This tracks rvirding/luerl#191 which fixes a decoder bug causing state issues when mixing Elixir and Lua functions.
davydog187
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks passed to functions implemented in Erlang as
erl_funcand the likes were not updating state correctly. It turns out that this issue is caused by decodedfunref's closing over the wrongStatevariable.For example, imagine the following Lua program
external_callis a function implemented in Erlang asThis program returns
luerlinterface