Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to alpine 3.20 #341

Merged
merged 1 commit into from
Jul 7, 2024
Merged

chore: update to alpine 3.20 #341

merged 1 commit into from
Jul 7, 2024

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Jun 3, 2024

Hi @rvolosatovs finally got around to making the changes needed to support Alpine 3.20. Main changes are:

  • protoc_gen_scala build no longer works on arm64 (I might have a solution for this soon)
  • protoc_gen_ts build is no longer possible due to the end of the pkg project in favour of Node Single Executable Applications. Since this is just the node binary with an additional payload, it is much easier to just include node in the final image and use NPM to install the plugin without complicated build/compile steps.
  • grpc_web build process changed due to Alpine no longer shipping libraries for static linking, so now we need to build protobuf itself first to static link against.
  • re-enable grpc_swift on arm64

@strophy strophy requested a review from rvolosatovs as a code owner June 3, 2024 20:52
@strophy strophy force-pushed the alpine3.20 branch 3 times, most recently from e40cf33 to ada38b9 Compare June 3, 2024 22:15
Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like CI is failing though, could you take a look?

Dockerfile Outdated Show resolved Hide resolved
@strophy strophy force-pushed the alpine3.20 branch 7 times, most recently from f6ea621 to 26ee2dd Compare June 9, 2024 12:31
@strophy strophy force-pushed the alpine3.20 branch 7 times, most recently from 7327e0c to 282fc7c Compare June 15, 2024 12:46
@strophy
Copy link
Collaborator Author

strophy commented Jul 7, 2024

@rvolosatovs I ended up creating an Alpine package for Bazel 7, now that I can use that here, the build works! Any more comments or let's merge, then I can tidy up the remaining PRs after this big change is in.

Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@strophy strophy merged commit 4d7d410 into main Jul 7, 2024
1 check passed
@strophy strophy deleted the alpine3.20 branch July 7, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants