Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI for 4.2.0 release #354

Merged
merged 3 commits into from
Jul 14, 2024
Merged

chore: fix CI for 4.2.0 release #354

merged 3 commits into from
Jul 14, 2024

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Jul 14, 2024

This PR switches to using a pre-packaged protoc-gen-js so we don't need to run Bazel ourselves, greatly speeding up the build.

It also disables Swift on ARM again. A cross-compile is needed for Swift, which should be easier when Swift 6 is released.

grpc_web is currently the slowest build but at least it works, maybe cross-compile is possible here too.

@strophy strophy requested a review from rvolosatovs as a code owner July 14, 2024 02:34
@strophy strophy force-pushed the apk-protoc-gen-js branch from 0bd94ad to c756db4 Compare July 14, 2024 02:39
@strophy strophy changed the title chore: switch to apk to install protoc-gen-js chore: fix CI for 4.2.0 release Jul 14, 2024
@strophy
Copy link
Collaborator Author

strophy commented Jul 14, 2024

@rvolosatovs this should allow us to release 4.2.0, please try again

@strophy
Copy link
Collaborator Author

strophy commented Jul 14, 2024

grpc_web cross-compile works! 🎉 build time improved from 1h20m to ~15m

@strophy strophy merged commit 2f98b01 into main Jul 14, 2024
1 check passed
@strophy strophy deleted the apk-protoc-gen-js branch July 14, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants