Prevent email from sending on pending payment for rvvup orders created in magento admin #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-onufriichuk
changed the title
| @@ -23,16 +23,35 @@ $url = $block->getUrl('rvvup/availability/index'); | |||
| Will create and share in order email | |||
| </label> | |||
| </div> | |||
| <script> | |||
| require(['jquery', 'Rvvup_Payments/js/available-payment'], function($, availablePayment) { | |||
| <?php if ($secureRenderer): ?> | |||
There was a problem hiding this comment.
Secure renderer is available for >2.4.0, so we can don't need to duplicate the logic.
| Available after placing order | ||
| </label> | ||
| </div> | ||
| <script> | ||
| require(['jquery', 'Rvvup_Payments/js/available-payment'], function($, availablePayment) { | ||
| <?php if ($secureRenderer): ?> |
There was a problem hiding this comment.
Secure renderer is available for >2.4.0, so we can don't need to duplicate the logic.
Comment on lines
11
to
14
| var element = ($('label[for="send_confirmation"]')); | ||
| if (element && element[0]) { | ||
| element[0].innerText = 'Order Confirmation email is always sent for Rvvup payment methods'; | ||
| } |
There was a problem hiding this comment.
Suggested change
| var element = ($('label[for="send_confirmation"]')); | |
| if (element && element[0]) { | |
| element[0].innerText = 'Order Confirmation email is always sent for Rvvup payment methods'; | |
| } | |
| $('label[for="send_confirmation"]').first().text("Order Confirmation email is always sent for Rvvup payment methods"); |
aashwin-rvvup
changed the title
aashwin-rvvup
changed the title
aashwin-rvvup
approved these changes
Aug 29, 2024
aashwin-rvvup
deleted the
feature/email-notifications-for-backend-orders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.