fix payment method icon size #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlom-rvvup
force-pushed
the
fix-payment-method-icons
branch
from
ac4526a
to
c68c336
Compare
| @@ -67,17 +67,17 @@ | |||
| margin-left: 5px; | |||
| } | |||
|
|
|||
| .rvvup-pay-by-bank-img, | |||
There was a problem hiding this comment.
Seems like we had this wrong in the first place (should be pay_by_bank,)
Also looks PHP cs doesn't like _ in class names 😂
There was a problem hiding this comment.
Looks like we have .rvvup-payment-logo on all our logos, but it was getting overridden by the data-bind so was being removed. if we add it in the data bind along with our rvvup-*-img then we can remove these individual ones and just have a style for rvvup-payment-logo.
Code in reference:
marlom-rvvup
force-pushed
the
fix-payment-method-icons
branch
from
459a6b0
to
8fea251
Compare
aashwin-rvvup
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.