Fixed scaling factors #1284
Merged
Fixed scaling factors #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be scaled by 2^10 bot by 2^16. See datasheet https://cdn-shop.adafruit.com/datasheets/TSL2561.pdf page 24
|
As a second eye here, I do see that
And subsequent arithmetic, page 27:
This (PR) looks good to me but I'd like to get someone who knows this area of the codebase better than I to take a peek... |
|
That looks like I just made a typing mistake. This fix is right. Will land when I return from parental leave in a week and a half, or someone else can merge before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be scaled by 2^10, not by 2^16. See datasheet https://cdn-shop.adafruit.com/datasheets/TSL2561.pdf page 24