Give Thermometer enable/disable methods #1346
Conversation
Updates board snapshot and serialize tests to account for the new thermometer `freq` property.
This is what I try to do, but not what always ends up happening, for a variety of reasons.
Such is the result of a relaxed contribution policy, but I'm ok with the incurred technical debt (for now).
Don't worry about that for now :)
This should be fine for now. |
There was a problem hiding this comment.
Brilliant!
Can you update the following:
- Add
enabledto: https://github.com/rwaldron/johnny-five/wiki/Thermometer#parameters - Add
freqto: https://github.com/rwaldron/johnny-five/wiki/Thermometer#shape - Add
enable()anddisable()to: https://github.com/rwaldron/johnny-five/wiki/Thermometer#api
| freq: opts.freq || 25, | ||
| previousFreq: opts.freq || 25, | ||
| }; | ||
| priv.set(this, state); |
| state.intervalId = setInterval(eventProcessing, newFreq); | ||
| } | ||
| } | ||
| }, |
| if (state.enabled) { | ||
| this.freq = state.freq; | ||
| } | ||
| } |
| }.bind(this), freq); | ||
| } | ||
| return this; | ||
| }; |
| } | ||
|
|
||
| return this; | ||
| }; |
| }, | ||
| enable: testEnable, | ||
| disable: testDisable, | ||
| constructDisabled: testConstructDisabled, |
|
Done: Documented |
Addresses #1297 by giving the
Thermometercomponentenable()anddisable()methods.I've added tests but I'm a little confused by the structure of the Thermometer unit tests - this feature lives on the prototype and should be the same for all controllers, but it looks like it has to be tested per-controller? But similar tests aren't applied to all controllers either. Let me know if I should make sure these tests get added to every controller, or if we can run them just once on the default controller, etc.
Thanks!