Assign colors, and then assign colors to keys

[fisher-alice]

@code-dot-org/johnny-five was recently updated to the latest release of its upstream in this PR.

@islemaster - While implementing Code.org customizations, I noticed a small bug in lib/led/rgb.js - RGB.prototype[Animation.keys] is assigned to RGB.colors before RGB.colors is assigned to an array of strings. This PR changes the order of these lines.

jira

[islemaster]

Cool. It looks like this regressed a couple of years ago in fbd7064 (here, to be exact).

Is this a review request? If so, will you please introduce a test to cover correct initialization of RGB.prototype[Animation.keys]?

[islemaster]

👋 Hi, by the way! I don't think we've met, but I've appreciated the maintenance you're doing here. I'm sure you're having great fun living with the consequences of all my bad decisions 😃

[fisher-alice]

here, to be exact

Yeah - there were a lot of updates made that day!

[fisher-alice]

👋 Hi, by the way! I don't think we've met, but I've appreciated the maintenance you're doing here. I'm sure you're having great fun living with the consequences of all my bad decisions 😃

Hello and nice to meet you! I feel like I already know you from all of your PRs I've read as I've updated CDO johnny-five. I recently shared lessons learned from johnny-five, and I included a shout-out to you - see slide 10.

[fisher-alice]

Cool. It looks like this regressed a couple of years ago in fbd7064 (here, to be exact).

Is this a review request? If so, will you please introduce a test to cover correct initialization of RGB.prototype[Animation.keys]?

Will do - thanks so much!

[fisher-alice]

Cool. It looks like this regressed a couple of years ago in fbd7064 (here, to be exact).
Is this a review request? If so, will you please introduce a test to cover correct initialization of RGB.prototype[Animation.keys]?

Will do - thanks so much!

@islemaster - just added a unit test - thanks for the suggestion.

[islemaster]

Looks great! Thanks!

[dtex]

This all looks good. Thanks for the catch and the patch.