Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch for dependent workspace crates #18

Closed
dmtrKovalenko opened this issue Aug 18, 2021 · 3 comments
Closed

Watch for dependent workspace crates #18

dmtrKovalenko opened this issue Aug 18, 2021 · 3 comments
Labels
feat New feature or request

Comments

@dmtrKovalenko
Copy link

dmtrKovalenko commented Aug 18, 2021

Is your feature request related to a problem? Please describe.
Right now when I have a create that depends on some other crate

# My wasm Cargo.toml
# ... 

[dependencies]
wasm-bindgen = "0.2.74"
lazy_static = "1.4.0"
console_error_panic_hook = "0.1.6"
# these 3 are local dependencies
rumotion-core = { path = "../../rumotion-core" }
video = { path = "../../video" }
svgr-macro = { path = "../../svgr-macro" }

rsw does not watch for file changes in dependent files. Only watches the original crate (https://github.com/lencx/vite-plugin-rsw/blob/main/src/compiler.ts#L164)

Describe the solution you'd like
RSW should parse the crate's Cargo.toml for dependencies that are local (have path attribute) and also watch subdirectories.

Describe alternatives you've considered
No alternatives :)

Additional context
I am working on fixing this for my own workflow, can make a PR if you are interested.

@dmtrKovalenko dmtrKovalenko added the feat New feature or request label Aug 18, 2021
@lencx
Copy link
Member

lencx commented Aug 18, 2021

Thanks, I will fix it in the next version, if you have a good idea, welcome to contribute PR.

lencx added a commit that referenced this issue Aug 19, 2021
lencx added a commit that referenced this issue Aug 21, 2021
@lencx
Copy link
Member

lencx commented Aug 21, 2021

@dmtrKovalenko Please try to upgrade v1.9.0, this feature is already supported.

@lencx lencx closed this as completed Sep 1, 2021
@dmtrKovalenko
Copy link
Author

Yeah I tested it and it works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants