-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various updates (see below) #7
Conversation
nsotgui
commented
Dec 19, 2020
- Add first pass on quickbooks bill
- Add github actions for build and future tests
- Refactor project layout according to recommended standards: https://github.com/golang-standards/project-layout
Add GitHub actions
Add create bill
Add test
Thanks for your effort. I'm going to merge this, but there are a few things we would hope to see done differently in future PRs:
I'm also going to undo the change to the project directory structure, because it doesn't sound like that's really a standard and it breaks compatibility. |
Make senses, I'll do it for future PR. I don't have a strong opinion on the pkg folder but you raised a good question on the compatibility, how about we start versioning/releasing versions of this repo? |