Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates (see below) #7

Merged
17 commits merged into from
Dec 23, 2020
Merged

Various updates (see below) #7

17 commits merged into from
Dec 23, 2020

Conversation

nsotgui
Copy link
Contributor

@nsotgui nsotgui commented Dec 19, 2020

@ghost
Copy link

ghost commented Dec 23, 2020

Thanks for your effort. I'm going to merge this, but there are a few things we would hope to see done differently in future PRs:

  • One issue per PR

  • Use amend and rebase to polish commits before opening a PR. Commit messages like 'try fix' make sense for personal use, but they don't help us make sense of the changes. In general, if a commit only fixes a problem with a previous commmit, it should be merged into it using amend or the 'fixup' command in interactive rebase.

I'm also going to undo the change to the project directory structure, because it doesn't sound like that's really a standard and it breaks compatibility.

@ghost ghost merged commit 59b43e9 into rwestlund:master Dec 23, 2020
@nsotgui
Copy link
Contributor Author

nsotgui commented Dec 23, 2020

Make senses, I'll do it for future PR.

I don't have a strong opinion on the pkg folder but you raised a good question on the compatibility, how about we start versioning/releasing versions of this repo?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant