-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement QUERY Method #2873
Comments
I'm of the opinion that we need a proper RFC to implement support for a method in this manner. The QUERY method has been in draft form for 3 years with various changes in its semantics in the same time, so I'm not as certain that we'll see a proper RFC soon. I would be in favor of a nice mechanism for custom methods in Rocket, which would supersede the need for this PR and others like it. |
Okay! I was just trying to help! Will |
Didn't mean to offend! |
No offense taken! It's excellent to bring things like this up, even if we don't merge them. My apologies if I indicated otherwise! |
You did not!! I was just being sure! I would love to take a crack at adding a
Would you be amenable to me opening a discussion PR for the way that we would want this implemented? Once we have a sense for how it should work, I could code it up! If that sounds okay, then I will get right on it! Thanks for giving me the chance to contribute! |
What's missing?
I am a huge fan of Rocket and thought that I could add support for the nearly-standardized QUERY method (https://www.ietf.org/archive/id/draft-ietf-httpbis-safe-method-w-body-05.html). I have a WIP PR that I will post to go along with this Feature Request. I have done my absolute best to make sure that I have followed all the proper steps.
Ideal Solution
I believe that the ideal solution is to simply add
QUERY
in the appropriate spot in the call(s) to thedefine_methods
macro. Because QUERY is not yet an RFC, there will be a few changes to thedefine_methods
macro so that the documentation is generated correctly.Why can't this be implemented outside of Rocket?
N/A
Are there workarounds usable today?
N/A
Alternative Solutions
No response
Additional Context
Again, thank you for all the work that you are doing on Rocket. I understand that the PR that I will post does not have tests and that is absolutely a requirement. However, I wanted to post early/often to see whether support for
QUERY
is something that you would consider. If it is, then I will absolutely add all the tests necessary and clean up anything else that I have done incorrectly.System Checks
The text was updated successfully, but these errors were encountered: