-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uuid, unicode-xid and base64 #1164
Conversation
Can you set the base branch for this to |
@SergioBenitez the UI tests are a pain since (I think) rust-lang/rust#64151 - see e.g. https://dev.azure.com/SergioBenitez/Rocket/_build/results?buildId=246&view=logs&jobId=fe4e408a-5576-5fa1-f2ab-61ac24819df6&taskId=7f0864f1-1a96-5cff-86e3-45ee63058371&lineStart=1343&lineEnd=1361&colStart=1&colEnd=1 This has two problems. First, there is trailing whitespace after one of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe of these deps uuid
is the only public one. This will be inconvenient for anyone using rocket and diesel in the same application, at least until diesel-rs/diesel#2205 makes it into a release.
Unfortunately |
Can you rebase this on |
Updates uuid, unicode-xid and base64 to reduce duplicate crate versions in projects.
It looks like the macOS build is failing because it's not finding mysqlclient |
Thank you! Merged in cd5f96a. |
Updates uuid, unicode-xid and base64 to reduce duplicate crate versions in projects.