Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uuid, unicode-xid and base64 #1164

Closed
wants to merge 1 commit into from
Closed

Update uuid, unicode-xid and base64 #1164

wants to merge 1 commit into from

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Oct 27, 2019

Updates uuid, unicode-xid and base64 to reduce duplicate crate versions in projects.

@jebrosen
Copy link
Collaborator

Can you set the base branch for this to master instead of async?

@paolobarbolini paolobarbolini changed the base branch from async to master October 27, 2019 15:51
@jebrosen
Copy link
Collaborator

@SergioBenitez the UI tests are a pain since (I think) rust-lang/rust#64151 - see e.g. https://dev.azure.com/SergioBenitez/Rocket/_build/results?buildId=246&view=logs&jobId=fe4e408a-5576-5fa1-f2ab-61ac24819df6&taskId=7f0864f1-1a96-5cff-86e3-45ee63058371&lineStart=1343&lineEnd=1361&colStart=1&colEnd=1

This has two problems. First, there is trailing whitespace after one of the |, so test.sh will complain after blessing the UI test. Second, that path isn't normalized/normalizable (at least not with $DIR). I had "fixed" this in the async branch by commenting out the complian-about-trailing-whitespace but the non-normalized path slipped my attention and it doesn't work.

Copy link
Collaborator

@jebrosen jebrosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe of these deps uuid is the only public one. This will be inconvenient for anyone using rocket and diesel in the same application, at least until diesel-rs/diesel#2205 makes it into a release.

@paolobarbolini
Copy link
Contributor Author

paolobarbolini commented Oct 27, 2019

Unfortunately uuid made a breaking change by changing uuid::parser::ParseError to uuid::Error so it wasn't possible to support both versions.

@jebrosen jebrosen assigned jebrosen and unassigned SergioBenitez Nov 15, 2019
contrib/lib/src/uuid.rs Outdated Show resolved Hide resolved
@jebrosen
Copy link
Collaborator

Can you rebase this on master to trigger a CI run?

Updates uuid, unicode-xid and base64 to reduce duplicate crate
versions in projects.
@paolobarbolini
Copy link
Contributor Author

It looks like the macOS build is failing because it's not finding mysqlclient

@jebrosen
Copy link
Collaborator

Thank you! Merged in cd5f96a.

@jebrosen jebrosen closed this Nov 30, 2019
@jebrosen jebrosen added the pr: merged This pull request was merged manually. label Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: merged This pull request was merged manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants