Small fixes for the v0.5 of the guide after review #1706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URI example is not referring to the handler defined in the previous subsection (Deriving `UriDisplay`) but to the handler in the subsection before that (Typed URIs). Unhiding brings that definition into rememberance for the user again so the example makes sense.
paulvt
force-pushed
the
reviewed-guide-small-fixes
branch
from
a431a1a
to
009a5b1
Compare
|
In light of the already existing PR #1690, I removed the IRC channel Libera.Chat fix commit. |
jebrosen
approved these changes
Jun 15, 2021
|
Merged in c1b1408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While brushing up my knowledge of the upcoming 0.5 features, I read through the entire guide and ran into a few small issues. Trying to help out with #1329 a bit, this PR fixes those issues.
Notes:
Libera.Chat has their own, accessible web chat now, so I linked that. If you'd still prefer Kiwi, I can revert that.