Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload templates when they have been changed on disk #537

Closed
wants to merge 28 commits into from
Closed

Reload templates when they have been changed on disk #537

wants to merge 28 commits into from

Commits on Aug 9, 2018

  1. template reload: Store template initialization callback inside Contex… 

    …t and provide reload() method
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    6f1ca6e View commit details
    Browse the repository at this point in the history

  2. template reload: Before each request in development mode, reload temp… 

    …lates if they have been changed on disk
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    06a356f View commit details
    Browse the repository at this point in the history

  3. template reload: properly handle failure case when instantiating a fi… 

    …leystem watcher
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d9ca78f View commit details
    Browse the repository at this point in the history

  4. template reload: split TemplateFairing and ManagedContext into a sepa… 

    …rate file
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    34cca3f View commit details
    Browse the repository at this point in the history

  5. template reload: clarify and document definition of ManagedContext

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    7c4d09c View commit details
    Browse the repository at this point in the history

  6. template reload: Keep previous templates and engines if there is a fa… 

    …ilure during reloading
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    5771e94 View commit details
    Browse the repository at this point in the history

  7. mostly revert Context: move the callback into the fairing, move the T… 

    …emplateWatcher into the debug version of ManagedContext
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    10b0c33 View commit details
    Browse the repository at this point in the history

  8. rename ManagedContext to ContextManager

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    91a4e38 View commit details
    Browse the repository at this point in the history

  9. remove Send+Sync+'static bounds where they are not needed

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    1a517cc View commit details
    Browse the repository at this point in the history

  10. register the on_request part of TemplateFairing only in debug_assertions

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    ef6159d View commit details
    Browse the repository at this point in the history

  11. refactor based on feedback

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    c301c13 View commit details
    Browse the repository at this point in the history

  12. move TemplateWatcher functionality directly into ManagedContext

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    8b54c86 View commit details
    Browse the repository at this point in the history

  13. merge watcher and corresponding receive queue into same Option field

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    5340c5a View commit details
    Browse the repository at this point in the history

  14. minor style fixes

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    4d3a0ff View commit details
    Browse the repository at this point in the history

  15. split the long warning lines

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    9807844 View commit details
    Browse the repository at this point in the history

  16. template reload: simplest test of a single template reload cycle

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    970056c View commit details
    Browse the repository at this point in the history

  17. switch watcher to raw_watcher 

    hopefully helps catch reload conditions more quickly, and notify
won't do any of its extra processing (that we ignore anyway)
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d94c4ba View commit details
    Browse the repository at this point in the history

  18. explicitly sync writes to files in the test; likely necessary on some… 

    … systems for changes to be detected properly
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    0f3daa1 View commit details
    Browse the repository at this point in the history

  19. unbreak rwf2#676 when combined with ContextManager

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    8b28f80 View commit details
    Browse the repository at this point in the history

  20. fully qualify Data, Request to avoid unused warnings in release mode

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    91204ae View commit details
    Browse the repository at this point in the history

  21. template_reload: attempt several times to observe filesystem changes

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d37ed0f View commit details
    Browse the repository at this point in the history

  22. refactor loop based on feedback. don't delete template file becuase i… 

    …t can break other concurrent tests
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    f4176df View commit details
    Browse the repository at this point in the history

  23. template reload tweaks and documentation

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    2585897 View commit details
    Browse the repository at this point in the history

  24. style changes, documentation additions/updates

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d75d1ec View commit details
    Browse the repository at this point in the history

  25. update note about reload being disabled in release & add to guide

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    e13036e View commit details
    Browse the repository at this point in the history

  26. include template reload test file so it does not appear as an untrack… 

    …ed file
    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    85f2a5d View commit details
    Browse the repository at this point in the history

  27. missing 'of'

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    dc34ab6 View commit details
    Browse the repository at this point in the history

  28. remove an unnecessary clone()

    @jebrosen
    jebrosen committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    3ecc02a View commit details
    Browse the repository at this point in the history