Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #643 #644

Closed
wants to merge 1 commit into from
Closed

Fix #643 #644

wants to merge 1 commit into from

Conversation

jebrosen
Copy link
Collaborator

Fixes #643

Deref of a Cow<'_, str> will always yield a str, so this should resolve any ambiguity during type inference.

@jebrosen
Copy link
Collaborator Author

Travis failed with this mystifying error repeated a few times:
found crate `rocket_codegen` compiled by an incompatible version of rustc [E0514]'

scripts/test.sh on my machine reports success.

@bjorn3 bjorn3 mentioned this pull request May 19, 2018
Closed
@SergioBenitez
Copy link
Member

I am seeing the same error Travis is reporting locally. Something else appears to be broken.

@SergioBenitez
Copy link
Member

Merged in ff5db84.

@SergioBenitez SergioBenitez added the pr: merged This pull request was merged manually. label May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
pr: merged This pull request was merged manually.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jebrosen @SergioBenitez @bjorn3