Update compiler tests for 2018-12-28 nightly. #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2018-12-28 nightly (Probably
fff01ccin rust-lang/rust#56999) exposed some more errors in the compiler tests, two trivial:fn mainuse rocket::http::RawStr;And one annoying one:
The derives for
UriDisplay{Path,Query}also deriveFromUriParam. Since the 2018-12-28 nightly,FooX: UriDisplay<Path>failing to be implemented shows up again as unsatisfied trait bounds for the implementation ofFromUriParam. I'm not thrilled with the current error output but wanted to at least ensure it passes the CI with this change.One possible fix would be to add a trivial where constraint (
impl FromUriParam<...> for &Foo1 where Foo1: UriDisplay<...>), but that feels inappropriate as a way to fix error messages and requires use of another unstable feature.