Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): update url to 0.5 #41

Merged
merged 1 commit into from
Nov 22, 2015
Merged

Conversation

untitaker
Copy link
Contributor

I also allow 0.2 because it still works with that version

@untitaker
Copy link
Contributor Author

I see, would you accept abandoning Rust 1.0 support in favor of just 1.4?

@untitaker
Copy link
Contributor Author

Perhaps wait for servo/rust-url#138

@alexcrichton
Copy link
Collaborator

Is there a particularly pressing reason to do this? This isn't a "public dependency" of this crate (e.g. not a shared type), so it should be fine to leave this as-is

@untitaker
Copy link
Contributor Author

No, no particular hurry. Just thought this might be useful because of binary
size.

On Fri, Nov 20, 2015 at 09:20:55AM -0800, Alex Crichton wrote:

Is there a particularly pressing reason to do this? This isn't a "public dependency" of this crate (e.g. not a shared type), so it should be fine to leave this as-is


Reply to this email directly or view it on GitHub:
#41 (comment)

@untitaker untitaker changed the title chore(cargo): update url to 0.4 chore(cargo): update url to 0.5 Nov 22, 2015
@untitaker
Copy link
Contributor Author

Updated PR to just pin to latest version.

alexcrichton added a commit that referenced this pull request Nov 22, 2015
chore(cargo): update url to 0.5
@alexcrichton alexcrichton merged commit c875d1d into rwf2:master Nov 22, 2015
@alexcrichton
Copy link
Collaborator

Thanks!

@SimonSapin
Copy link
Contributor

Could you get this on crates.io? Thanks!

CC servo/servo#8446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants